fix(typeinfo): expanding seq doesn't clear locations #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= New seq slots are now zeroed when expanding the seq via `invokeNewSeq` or `extendSeq`, making the behaviour consistent with `setLen` and `newSeq`, and also fixing crashes with `marshal` caused by the uninitialized memory. Details ======= Zeroing the memory is not correct for types that don't have a zero- default, but those cannot be detected with just RTTI. Zeroing the memory is usually still better then leaving it as is. For the JavaScript and VM backends, the zeroMem call is excluded from compilation. Using `invokeNewSeq` and `extendSeq` is already not possible on these backends.
saem
approved these changes
Sep 25, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New seq slots are now zeroed when expanding the seq via
invokeNewSeqor
extendSeq, making the behaviour consistent withsetLenandnewSeq, and also fixing crashes withmarshalcaused by theuninitialized memory.
Details
Zeroing the memory is not correct for types that don't have a zero-
default, but those cannot be detected with just RTTI. Zeroing the
memory is usually still better then leaving it as is.
For the JavaScript and VM backends, the
zeroMemcall is excludedfrom compilation. Using
invokeNewSeqandextendSeqis alreadynot possible on these backends.
Fixes #1462